feat(smtp): Add hostname to SMTP #1076
Conversation
|
Will also update docs on https://develop.sentry.dev/self-hosted/email/ |
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
LGTM
With such a name, in docs, you need to make it very clear this is not to be filled by an email but rather than with the server name (FQDN) that is the one filled in the reverse DNS PTR.
Example:
- To find out the IP
dig sentry-server.company.tld +short> IP - Use the IP to see to what it reverse resolves
dig -x $IP +short> result
Adding a disclaimer that people NEED to add the server to their SPF field would be great, nobody seems to care enough about it..
Use the $result to fill the value
This will do that the chain is resolvable
email>smtp>helo $result>spf check>name resolves the ip that we are receiving mail from>spf ok (I over simplified)
Co-authored-by: William Desportes <williamdes@wdes.fr>
|
@williamdes thanks a lot for the review! I'm okay renaming the variable, any suggestions? Should we add Regarding docs, would you like to give it a shot yourself as you seem to be more knowledgeable than myself regarding mailing? 😄 |
Sure, I would love to get all Sentry installations perfectly email compatible, let me know where I can contribute _HOST would be perfect a I am not sure everyone knows what a FQDN is Maybe _HOSTNAME but I am not sure where the python setting is actually used |
Co-authored-by: Chad Whitacre <chadwhitacre@sentry.io>
| SENTRY_OPTIONS["mail.list-namespace"] = env('SENTRY_MAIL_HOST', 'localhost') | ||
| SENTRY_OPTIONS["mail.from"] = f"sentry@{SENTRY_OPTIONS['mail.list-namespace']}" |
There was a problem hiding this comment.
This looks right and wrong to me
I was thinking SENTRY_MAIL_HOST was used for the HELO command, but it seems like not
The value of the HELO command can be first.server.company.tld but send mails as domain2.tld
This is what did happen at phpMyAdmin, we send Sentry reports as xxx@phpmyadmin.net and use a HELO value of server.hostingcompany.tld
Could you please link me the actual uses of this two variables ?
There was a problem hiding this comment.
The value of the HELO command can be first.server.company.tld but send mails as domain2.tld
This is fine, they don't need to be in sync. We are just setting sensible defaults for a good out-of-the-box experience. One can change these as freely as they can.
Could you please link me the actual uses of this two variables ?
This is the code that uses them: https://github.com/getsentry/sentry/blob/2103815733832c1e463142f225f6bd2652b7e87e/src/sentry/utils/email.py#L277-L283
SENTRY_MAIL_HOST is not used, it is something I just made up for easy configuration in self-hosted. The mail server settings are here: https://github.com/getsentry/onpremise/blob/674a600770acad37ab8560e323e38ead49b0cf97/sentry/config.example.yml#L10-L16
By default we use the smtp service based on exim4 but it is also fully configurable.
Fixes #1045.