-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Allow configuring Sentry taskworker concurrency via env #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aminvakil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this.
Also for future reference, this is the PR which implemented concurrency in taskworker:
As @markstory has said in PR:
This will help enable higher CPU usage in worker pods, as we can pack more concurrent CPU operations into each pod (at the cost of memory).
And @aldy505 had a discussion about this number in https://github.com/getsentry/self-hosted/pull/3738/changes#r2133139080 which I'm adding here for reference as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
It replaces the hardcoded
--concurrencyvalue indocker-compose.ymlwithSENTRY_TASKWORKER_CONCURRENCY, improving flexibility for different deployment sizes while preserving the existing default.