Skip to content

fix: manual image tags rollback to nightly#4204

Merged
aldy505 merged 1 commit intomasterfrom
aldy505/fix/manual-image-tags
Mar 4, 2026
Merged

fix: manual image tags rollback to nightly#4204
aldy505 merged 1 commit intomasterfrom
aldy505/fix/manual-image-tags

Conversation

@aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Mar 4, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Changelog Preview

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • Manual image tags rollback to nightly by aldy505 in #4204

Internal Changes 🔧

  • (deps) Bump minimatch from 9.0.5 to 9.0.7 in /_integration-test/nodejs by dependabot in #4189

🤖 This preview updates automatically when you update the PR.

@aldy505 aldy505 enabled auto-merge (squash) March 4, 2026 15:11
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't quite catch up what happened with 26.2.0 and what was wrong in GHA responsible for creating and fixing release tags.

But this PR is fine anyway.

@aldy505 aldy505 merged commit d79ab10 into master Mar 4, 2026
18 checks passed
@aldy505 aldy505 deleted the aldy505/fix/manual-image-tags branch March 4, 2026 16:37
@aldy505
Copy link
Collaborator Author

aldy505 commented Mar 4, 2026

Sorry, I didn't quite catch up what happened with 26.2.0 and what was wrong in GHA responsible for creating and fixing release tags.

But this PR is fine anyway.

@aminvakil we merged the Craft update PR to perform new releases via Craft. On 26.2.0, the resulting docker tags in .env file on self-hosted are still "nightly" where it should be 26.2.0. Then we released 26.2.1, which fix the first problem, but causes another problem of the tags were not reverted back to "nightly".

@aminvakil
Copy link
Collaborator

Sorry, I didn't quite catch up what happened with 26.2.0 and what was wrong in GHA responsible for creating and fixing release tags.
But this PR is fine anyway.

@aminvakil we merged the Craft update PR to perform new releases via Craft. On 26.2.0, the resulting docker tags in .env file on self-hosted are still "nightly" where it should be 26.2.0. Then we released 26.2.1, which fix the first problem, but causes another problem of the tags were not reverted back to "nightly".

@aldy505 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants