Merged
Conversation
Better compatiblity when developing self-hosted in all platforms, pre-commit really sucks when I'm on Windows. Luckily, prek is a simple drop-in replacement and we need to change nothing.
Changelog Preview📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Collaborator
Author
|
Blocked by j178/prek#1838 |
Collaborator
Author
|
CI is green! |
aminvakil
approved these changes
Mar 24, 2026
BYK
approved these changes
Mar 24, 2026
| jobs: | ||
| changelog-preview: | ||
| uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2 | ||
| uses: getsentry/craft/.github/workflows/changelog-preview.yml@f4889d04564e47311038ecb6b910fef6b6cf1363 # 2.25.0 |
Member
There was a problem hiding this comment.
Keep this dynamic.
Suggested change
| uses: getsentry/craft/.github/workflows/changelog-preview.yml@f4889d04564e47311038ecb6b910fef6b6cf1363 # 2.25.0 | |
| uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2 |
Collaborator
Author
There was a problem hiding this comment.
I apply regular updates from dependanbot, so it's fine?
Member
There was a problem hiding this comment.
And keep the churn and useless PRs and commits and CI time?
| - name: Get auth token | ||
| id: token | ||
| uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2.2.1 | ||
| uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # v3.0.0 |
Member
There was a problem hiding this comment.
This one too.
Suggested change
| uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # v3.0.0 | |
| uses: actions/create-github-app-token@v3 |
Collaborator
Author
There was a problem hiding this comment.
Why shouldnt we pin this one?
Collaborator
Author
There was a problem hiding this comment.
Well tbf we do pin actions/checkout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better compatiblity when developing self-hosted in all platforms, pre-commit really sucks when I'm on Windows.
Luckily, prek is a simple drop-in replacement and we need to change nothing.