Make images versions configurable #596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default `SENTRY_VERSION=latest` in `.env`, but if I set it to `SENTRY_VERSION=b7d0b43` then install script fails, because there is no such image tag for `getsentry/snuba` and `getsentry/relay`, but `docker-compose.yml` contained `image: 'getsentry/snuba:$SENTRY_VERSION'` and `image: 'getsentry/relay:$SENTRY_VERSION'`. I propose to make configurable tags for snuba and relay images.
Author
|
Reopening PR for Travis rebuild with new timeout settings. |
BYK
requested changes
Jul 16, 2020
Member
BYK
left a comment
BYK
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! I had something similar in mind but using SNUBA_IMAGE and RELAY_IMAGE similar to the one we already have: SENTRY_IMAGE.
Separating these would make our release process more complex and your PR would break it as it currently is.
Would you mind if I suggest you to use SENTRY_IMAGE for now and then create a PR of my own implementing the solution I mentioned? We'll need that for some tests in the near future.
Author
|
I don't mind closing my PR. Thanks for sharing your future plans about implementing this feature. |
BYK
added a commit
that referenced
this pull request
Jul 17, 2020
This change allows one to override any Sentry service image, mostly for testing purposes. It also removes the SENTRY_VERSION variable as docker-compose makes it very hard to cascade default values for these. Next step is to have integration tests in getsentry/snuba and getsentry/relay (and possibly for getsentry/symbolicator) for getsentry/onpremise using this PR. Also related: #596.
BYK
added a commit
that referenced
this pull request
Jul 17, 2020
#602) This change allows one to override any Sentry service image, mostly for testing purposes. It also removes the SENTRY_VERSION variable as docker-compose makes it very hard to cascade default values for these. Next step is to have integration tests in getsentry/snuba and getsentry/relay (and possibly for getsentry/symbolicator) for getsentry/onpremise using this PR. Also related: #596.
BYK
added a commit
that referenced
this pull request
Jul 21, 2020
#602) This change allows one to override any Sentry service image, mostly for testing purposes. It also removes the SENTRY_VERSION variable as docker-compose makes it very hard to cascade default values for these. Next step is to have integration tests in getsentry/snuba and getsentry/relay (and possibly for getsentry/symbolicator) for getsentry/onpremise using this PR. Also related: #596.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
SENTRY_VERSION=latestin.env, but if I set it toSENTRY_VERSION=b7d0b43then install script fails, because there is no such image tag forgetsentry/snubaandgetsentry/relay, butdocker-compose.ymlcontainedimage: 'getsentry/snuba:$SENTRY_VERSION'andimage: 'getsentry/relay:$SENTRY_VERSION'.I propose to make configurable tags for snuba and relay images.