Skip to content

fix(install): Read and set .env in install.sh #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2020
Merged

fix(install): Read and set .env in install.sh #600

merged 5 commits into from
Jul 17, 2020

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jul 17, 2020

Fixes #597.

@BYK BYK requested a review from jan-auer July 17, 2020 08:46
@BYK BYK requested a review from untitaker July 17, 2020 11:26
@BYK BYK merged commit 094d8e3 into master Jul 17, 2020
@BYK BYK deleted the byk/fix/env-in-install branch July 17, 2020 12:29
BYK added a commit that referenced this pull request Jul 21, 2020
@BYK
fix(install): Read and set .env in install.sh (#600)
66a1b46 
Fixes #597.
@chadwhitacre chadwhitacre mentioned this pull request Aug 17, 2020
Merged
BYK pushed a commit that referenced this pull request Aug 17, 2020
@chadwhitacre
fix(env): Read and set .env in install.sh, portably (#626)
67f7091 
h/t https://unix.stackexchange.com/a/79077

Fixes #622, cf. #600 

cc: @NullIsNot0
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@untitaker untitaker untitaker approved these changes

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ./install.sh refers to SENTRY_VERSION from .env but doesn't read it

3 participants

@BYK @untitaker