Conversation
Member
|
Nice, thanks. I guess the integration tests are still a bit crappy though and there are a few bugs in the python sdk on shutdown. I'll check on Mo. |
This was referenced Aug 25, 2018
untitaker
approved these changes
Aug 26, 2018
Member
untitaker
left a comment
untitaker
left a comment
There was a problem hiding this comment.
let's merge this, it's a step forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't actually fix the tests but it makes travis execute them. Not entirely sure what is happening though. The weirdest part is that some internal errors that the relay itself reports to sentry seem to go to the mini sentry.