Fix: Accept undefined as value for tags.#656
Merged
lucas-zimerman merged 4 commits intomainfrom Jun 3, 2024
Merged
Conversation
lucas-zimerman
changed the title
krystofwoldrich
approved these changes
May 27, 2024
Contributor
krystofwoldrich
left a comment
krystofwoldrich
left a comment
There was a problem hiding this comment.
LGTM 🚀
I guess we can't add easy test to check that Sentry.setTag('tagKey', undefined) is translated by Capacitor to call.hasKey('value')===false.
Contributor
|
@lucas-zimerman Could you open the same fix for React Native? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the behaviour on JavaScript with undefined value is to remove the tag, this wasn't respected on the native SDKs, this PR ensures that the behaviour form JavaScript also happens on the Native layer, by removing the tag.
Fixes: #647