fix: use commonjs modules in commonjs build#773
Merged
Conversation
maxnowack
force-pushed
the
patch-1
branch
2 times, most recently
from
55ce8cc to
67d81d5
Compare
lucas-zimerman
requested changes
Nov 11, 2024
Collaborator
lucas-zimerman
left a comment
lucas-zimerman
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Your PR looks great! But before merging, could you remove the package-lock.json file?
Contributor
Author
|
@lucas-zimerman Oh, sorry. I accidentally committed the |
lucas-zimerman
approved these changes
Nov 12, 2024
Collaborator
lucas-zimerman
left a comment
lucas-zimerman
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Contributor
Author
|
@lucas-zimerman is there an ETA for when this change will be released? 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #772