Remove `try!` from test code

[armcknight]

Description

Previously I've removed potential crashers in test code in #4125 and #4132, but I guess I didn't think to look for this. Just noticed it, and we currently have 69 instances. Most should be an easy conversion of the enclosing test cases to throws, but a few are property intializers on Fixture instances that will need a little more work to maybe change to optional types.

[philipphofmann]

If we can't make it in a big bang, we should tackle this opportunistically. Whenever we change a test class that uses try!, we can remove it. We should enable the swiftlint rule to avoid having try! again in the future, once we ditched all of these.

[philprime]

I agree that we should tackle this and enable the swiftlint rule. Maybe it's worth splitting up the refactoring for tests and for SDK into two PRs, as one affects the changelog while the other doesn't

[philipphofmann]

We don't use try! in the SDK code. We only hjave in the test code. The swiftlint rule is active for SDK code,

sentry-cocoa/.swiftlint.yml

Line 32 in 5290314

- force_try

[philipphofmann]

Slightly related: I removed plenty of force_unwraps with:

• test: Remove force_unwrap for Serialization tests #5019
• test: Remove force_unwrap for NetworkTrackerTests #5020
• test: Remove force_unwrap for SessionTests #5021

[philprime]

To mention this comment this comment here:

Since Swift 5.5 it is possible to convert a String to UTF 8 Data without nullability.

https://forums.swift.org/t/can-encoding-string-to-data-with-utf8-fail/22437/3

There's even a SwiftLint rule to point this out:

https://realm.github.io/SwiftLint/non_optional_string_data_conversion.html

Changing this could remove many force unwraps