test: Fix checkTotalFrames #3485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't base min and max expected frames on the current frame rate as it could change while rendering frames.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3485 +/- ##
=============================================
+ Coverage 89.079% 89.080% +0.001%
=============================================
Files 526 526
Lines 56928 56915 -13
Branches 20478 20469 -9
=============================================
- Hits 50711 50700 -11
+ Misses 5300 5296 -4
- Partials 917 919 +2 see 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't base min and max expected frames on the current frame rate, as it could change while rendering frames.
That test sometimes fails, see https://github.com/getsentry/sentry-cocoa/actions/runs/7103552377/job/19336751278?pr=3482.
#skip-changelog