Skip to content

test: Fix checkTotalFrames #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023
Merged

test: Fix checkTotalFrames #3485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions Samples/iOS-Swift/iOS-SwiftUITests/LaunchUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,19 +109,16 @@ class LaunchUITests: BaseUITest {
let endDate = Date()

let secondsBetween = endDate.timeIntervalSince(startDate)

// Retrieving the number of frames from the text label is inaccurate.
// Therefore, we add a one-second tolerance for the expected amount of frames.
// We only want to validate if the number of total frames is entirely off.
let maximumFramesPerSecond = Double(UIScreen.main.maximumFramesPerSecond)

let expectedMinimumTotalFrames = (secondsBetween - 1.0) * maximumFramesPerSecond
let expectedMaximumTotalFrames = (secondsBetween + 1.0) * maximumFramesPerSecond

// We don't calculate the min and max values based on the frame rate, as it could have changed while waiting for them to render.
// Instead, we pick the minimum value based on 60fps and the maximum value based on 120fps.
let expectedMinimumTotalFrames = (secondsBetween - 1.0) * 60
let expectedMaximumTotalFrames = (secondsBetween + 1.0) * 120

let actualTotalFrames = Double(endTotalFrames - startTotalFrames)

XCTAssertGreaterThanOrEqual(actualTotalFrames, expectedMinimumTotalFrames, "Actual frames:\(actualTotalFrames) should be greater than \(expectedMinimumTotalFrames) with frame rate of \(maximumFramesPerSecond)")
XCTAssertLessThanOrEqual(actualTotalFrames, expectedMaximumTotalFrames, "Actual frames:\(actualTotalFrames) should be less than \(expectedMaximumTotalFrames) with frame rate of \(maximumFramesPerSecond)")
XCTAssertGreaterThanOrEqual(actualTotalFrames, expectedMinimumTotalFrames, "Actual frames:\(actualTotalFrames) should be greater than \(expectedMinimumTotalFrames)")
XCTAssertLessThanOrEqual(actualTotalFrames, expectedMaximumTotalFrames, "Actual frames:\(actualTotalFrames) should be less than \(expectedMaximumTotalFrames)")
}

/**
Expand Down