ref: Improve ClientAttachmentProcessor

[philipphofmann]

Specify types for NSArrays, rename attachmentsForEvent to processAttachmentsForEvent, only pass attachments to processAttachmentsForEvent, remove not required nullable for SentryClientAttachmentProcessor.

Came up while investigating GH-4936.

#skip-changelog

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.701%. Comparing base (fd1c994) to head (79baae9).
Report is 5 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #5001       +/-   ##
=============================================
+ Coverage   92.608%   92.701%   +0.093%     
=============================================
  Files          672       672               
  Lines        82199     82206        +7     
  Branches     28819     29842     +1023     
=============================================
+ Hits         76123     76206       +83     
+ Misses        5983      5903       -80     
- Partials        93        97        +4     

Files with missing lines	Coverage Δ
Sources/Sentry/SentryClient.m	98.459% <100.000%> (+0.008%)	⬆️
Sources/Sentry/SentryScreenshotIntegration.m	92.156% <ø> (ø)
Sources/Sentry/SentryViewHierarchyIntegration.m	100.000% <ø> (ø)
.../Screenshot/SentryScreenshotIntegrationTests.swift	99.447% <100.000%> (ø)
...ierarchy/SentryViewHierarchyIntegrationTests.swift	99.350% <100.000%> (ø)
Tests/SentryTests/SentryClientTests.swift	98.580% <100.000%> (+0.195%)	⬆️

... and 23 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1c994...79baae9. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1208.87 ms	1235.86 ms	26.98 ms
Size	22.30 KiB	833.29 KiB	810.98 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
bdd896e	1211.19 ms	1239.06 ms	27.87 ms
bd2afa6	1245.24 ms	1263.18 ms	17.94 ms
7fe37ab	1236.10 ms	1258.83 ms	22.73 ms
8a0317e	1259.18 ms	1261.38 ms	2.20 ms
b448017	1234.59 ms	1252.55 ms	17.96 ms
ca507ec	1224.43 ms	1246.04 ms	21.61 ms
7bb0873	1215.65 ms	1235.00 ms	19.35 ms
3478fc5	1237.94 ms	1251.13 ms	13.19 ms
f587451	1271.63 ms	1275.90 ms	4.27 ms
ebfe678	1234.63 ms	1254.52 ms	19.89 ms

App size

Revision	Plain	With Sentry	Diff
bdd896e	22.31 KiB	780.75 KiB	758.43 KiB
bd2afa6	20.76 KiB	420.55 KiB	399.79 KiB
7fe37ab	21.58 KiB	542.28 KiB	520.70 KiB
8a0317e	22.85 KiB	414.06 KiB	391.21 KiB
b448017	22.32 KiB	761.25 KiB	738.93 KiB
ca507ec	21.58 KiB	616.76 KiB	595.17 KiB
7bb0873	22.85 KiB	407.09 KiB	384.24 KiB
3478fc5	21.58 KiB	654.59 KiB	633.01 KiB
f587451	20.76 KiB	435.25 KiB	414.49 KiB
ebfe678	22.31 KiB	775.27 KiB	752.95 KiB

[philprime]

Thanks for adding these types!