Skip to content

Conversation

@philprime
Copy link
Member

We shipped a hotfix 8.49.2, we need to merge the changes to main.

#skip-changelog

armcknight and others added 2 commits April 29, 2025 17:08
… configuration (#5143)

Co-authored-by: Philip Niedertscheider <phil.niedertscheider@sentry.io>
@philipphofmann
Copy link
Member

philipphofmann commented Apr 30, 2025

@philprime, it would be great to get this PR ready for review quickly to avoid merge conflicts, please.

@philprime philprime self-assigned this Apr 30, 2025
@philprime philprime marked this pull request as ready for review April 30, 2025 10:09
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 92.90323% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.796%. Comparing base (c40037e) to head (692ab99).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Sentry/SentryFileManager.m 84.126% 10 Missing ⚠️
Sources/Sentry/SentryProfiler.mm 0.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5154       +/-   ##
=============================================
+ Coverage   92.774%   92.796%   +0.021%     
=============================================
  Files          677       677               
  Lines        84275     84419      +144     
  Branches     30658     30706       +48     
=============================================
+ Hits         78186     78338      +152     
+ Misses        5987      5981        -6     
+ Partials       102       100        -2     
Files with missing lines Coverage Δ
...urces/Sentry/Profiling/SentryProfilerTestHelpers.m 87.804% <100.000%> (ø)
Sources/Sentry/SentryMeta.m 50.000% <ø> (ø)
...ts/SentryTests/Helper/SentryFileManagerTests.swift 96.945% <100.000%> (+0.231%) ⬆️
Sources/Sentry/SentryProfiler.mm 90.000% <0.000%> (+3.253%) ⬆️
Sources/Sentry/SentryFileManager.m 94.412% <84.126%> (-0.744%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40037e...692ab99. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.63 ms 1252.81 ms 21.18 ms
Size 22.30 KiB 852.05 KiB 829.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c6504da 1232.06 ms 1243.28 ms 11.22 ms
c6b920a 1239.53 ms 1256.53 ms 17.00 ms
318a891 1245.14 ms 1259.02 ms 13.88 ms
5e769dd 1216.24 ms 1245.74 ms 29.50 ms
7cd187e 1243.04 ms 1244.79 ms 1.75 ms
4329cdb 1206.96 ms 1227.74 ms 20.78 ms
6813f7c 1232.23 ms 1251.47 ms 19.24 ms
4350d44 1228.75 ms 1246.75 ms 18.00 ms
a176fc4 1226.24 ms 1247.50 ms 21.26 ms
25bcc50 1237.69 ms 1258.40 ms 20.71 ms

App size

Revision Plain With Sentry Diff
c6504da 20.76 KiB 414.44 KiB 393.69 KiB
c6b920a 21.58 KiB 631.19 KiB 609.61 KiB
318a891 22.30 KiB 750.02 KiB 727.72 KiB
5e769dd 21.58 KiB 572.21 KiB 550.62 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
4329cdb 22.30 KiB 833.10 KiB 810.80 KiB
6813f7c 21.58 KiB 614.86 KiB 593.28 KiB
4350d44 21.58 KiB 629.82 KiB 608.24 KiB
a176fc4 22.84 KiB 403.24 KiB 380.39 KiB
25bcc50 20.76 KiB 427.23 KiB 406.46 KiB

@philprime
Copy link
Member Author

The failing "Changes in High Risk Code" will be fixed with #5157.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@philprime philprime merged commit 20c8177 into main Apr 30, 2025
78 of 79 checks passed
@philprime philprime deleted the hotfix/8.49.2 branch April 30, 2025 11:21
Copy link

@Classicrichblog Classicrichblog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants