-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix(profiling): Change path of non-sandboxed macOS app launch profile configuration #5154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… configuration (#5143) Co-authored-by: Philip Niedertscheider <phil.niedertscheider@sentry.io>
|
@philprime, it would be great to get this PR ready for review quickly to avoid merge conflicts, please. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5154 +/- ##
=============================================
+ Coverage 92.774% 92.796% +0.021%
=============================================
Files 677 677
Lines 84275 84419 +144
Branches 30658 30706 +48
=============================================
+ Hits 78186 78338 +152
+ Misses 5987 5981 -6
+ Partials 102 100 -2
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c6504da | 1232.06 ms | 1243.28 ms | 11.22 ms |
| c6b920a | 1239.53 ms | 1256.53 ms | 17.00 ms |
| 318a891 | 1245.14 ms | 1259.02 ms | 13.88 ms |
| 5e769dd | 1216.24 ms | 1245.74 ms | 29.50 ms |
| 7cd187e | 1243.04 ms | 1244.79 ms | 1.75 ms |
| 4329cdb | 1206.96 ms | 1227.74 ms | 20.78 ms |
| 6813f7c | 1232.23 ms | 1251.47 ms | 19.24 ms |
| 4350d44 | 1228.75 ms | 1246.75 ms | 18.00 ms |
| a176fc4 | 1226.24 ms | 1247.50 ms | 21.26 ms |
| 25bcc50 | 1237.69 ms | 1258.40 ms | 20.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c6504da | 20.76 KiB | 414.44 KiB | 393.69 KiB |
| c6b920a | 21.58 KiB | 631.19 KiB | 609.61 KiB |
| 318a891 | 22.30 KiB | 750.02 KiB | 727.72 KiB |
| 5e769dd | 21.58 KiB | 572.21 KiB | 550.62 KiB |
| 7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
| 4329cdb | 22.30 KiB | 833.10 KiB | 810.80 KiB |
| 6813f7c | 21.58 KiB | 614.86 KiB | 593.28 KiB |
| 4350d44 | 21.58 KiB | 629.82 KiB | 608.24 KiB |
| a176fc4 | 22.84 KiB | 403.24 KiB | 380.39 KiB |
| 25bcc50 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
|
The failing "Changes in High Risk Code" will be fixed with #5157. |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Classicrichblog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
We shipped a hotfix 8.49.2, we need to merge the changes to
main.#skip-changelog