ci: Validate XCFramework architectures#7883
Merged
philprime merged 2 commits intoMay 8, 2026
Merged
Conversation
philprime
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin and
philipphofmann
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f601422. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 39908fa | 1216.45 ms | 1247.67 ms | 31.22 ms |
| 1db3ef0 | 3762.07 ms | 3780.62 ms | 18.56 ms |
| 7b3193a | 1214.08 ms | 1250.08 ms | 36.00 ms |
| 87bd6e0 | 1240.02 ms | 1246.75 ms | 6.73 ms |
| e55e60d | 1217.93 ms | 1251.80 ms | 33.86 ms |
| 82293b9 | 1205.29 ms | 1241.32 ms | 36.03 ms |
| bb809e8 | 1229.33 ms | 1262.54 ms | 33.21 ms |
| 7e3cf1f | 1208.80 ms | 1244.33 ms | 35.52 ms |
| 14dc1d7 | 1207.65 ms | 1228.72 ms | 21.08 ms |
| 664430d | 1225.83 ms | 1256.84 ms | 31.01 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 39908fa | 24.14 KiB | 1.13 MiB | 1.11 MiB |
| 1db3ef0 | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| 7b3193a | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 87bd6e0 | 24.14 KiB | 1.13 MiB | 1.11 MiB |
| e55e60d | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 82293b9 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| bb809e8 | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| 7e3cf1f | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| 14dc1d7 | 24.14 KiB | 1.13 MiB | 1.11 MiB |
| 664430d | 24.14 KiB | 1.12 MiB | 1.10 MiB |
Catch jq failures before reading library records so malformed XCFramework metadata cannot report a passing validation without checking any binaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a reusable XCFramework architecture validator that compares each Info.plist SupportedArchitectures entry with the architectures reported by lipo for the packaged binary.
Wire the validator into the shared XCFramework assembly workflow, the SentryObjC assembly workflow, and local XCFramework builds. This makes missing slices fail with an explicit expected-versus-actual architecture message instead of surfacing later as a linker error.
Also verify codesign immediately after signing release XCFrameworks in the compression helper.
Stacked on #7598.
#skip-changelog