Skip to content

fix(replay): correct file type for SentrySessionReplayHybridSDK.m in pbxproj#7911

Merged
philprime merged 2 commits into
mainfrom
alwx/bugfix/replay-hybrid-sdk-pbxproj-filetype
May 19, 2026
Merged

fix(replay): correct file type for SentrySessionReplayHybridSDK.m in pbxproj#7911
philprime merged 2 commits into
mainfrom
alwx/bugfix/replay-hybrid-sdk-pbxproj-filetype

Conversation

@alwx
Copy link
Copy Markdown
Contributor

@alwx alwx commented May 18, 2026

📜 Description

The file was declared with lastKnownFileType = sourcecode.c.h instead of sourcecode.c.objc, causing Xcode to treat it as a header. As a result the implementation was silently skipped during compilation of the xcframework variants (Sentry, Sentry-Dynamic, …), and consumers of the published xcframework hit Undefined symbol: _OBJC_CLASS_$_SentrySessionReplayHybridSDK at link time.

💡 Motivation and Context

We need that for sentry-react-native (getsentry/sentry-react-native#5780)

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.476%. Comparing base (53097d6) to head (27eb94a).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7911       +/-   ##
=============================================
- Coverage   85.541%   85.476%   -0.066%     
=============================================
  Files          487       488        +1     
  Lines        29672     29690       +18     
  Branches     12881     12894       +13     
=============================================
- Hits         25382     25378        -4     
- Misses        4241      4262       +21     
- Partials        49        50        +1     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53097d6...27eb94a. Read the comment docs.

@philprime philprime added the ready-to-merge Use this label to trigger all PR workflows label May 19, 2026
@philprime philprime enabled auto-merge (squash) May 19, 2026 08:30
@sentry
Copy link
Copy Markdown

sentry Bot commented May 19, 2026

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
SDK-Size io.sentry.sample.SDK-Size 9.13.0 (1) Release

⚙️ sentry-cocoa Build Distribution Settings

@github-actions
Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.10 ms 1265.32 ms 33.22 ms
Size 24.14 KiB 1.16 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c67ced3 1223.22 ms 1256.15 ms 32.93 ms
44b7b59 1211.91 ms 1248.90 ms 36.99 ms
ffb6adc 1218.60 ms 1247.47 ms 28.87 ms
37fd1b7 1227.56 ms 1262.45 ms 34.89 ms
787537a 1218.35 ms 1251.72 ms 33.38 ms
92bcc8f 1233.43 ms 1270.20 ms 36.77 ms
65c13c5 1234.47 ms 1263.10 ms 28.63 ms
53097d6 1218.02 ms 1251.70 ms 33.68 ms
8180609 1214.67 ms 1243.36 ms 28.69 ms
ce900e7 1212.40 ms 1244.57 ms 32.18 ms

App size

Revision Plain With Sentry Diff
c67ced3 24.14 KiB 1.16 MiB 1.13 MiB
44b7b59 24.14 KiB 1.15 MiB 1.13 MiB
ffb6adc 24.14 KiB 1.15 MiB 1.12 MiB
37fd1b7 24.14 KiB 1.15 MiB 1.13 MiB
787537a 24.14 KiB 1.15 MiB 1.12 MiB
92bcc8f 24.14 KiB 1.15 MiB 1.13 MiB
65c13c5 24.14 KiB 1.15 MiB 1.12 MiB
53097d6 24.14 KiB 1.16 MiB 1.13 MiB
8180609 24.14 KiB 1.16 MiB 1.13 MiB
ce900e7 24.14 KiB 1.15 MiB 1.13 MiB

@philprime philprime merged commit e0946cf into main May 19, 2026
222 of 225 checks passed
@philprime philprime deleted the alwx/bugfix/replay-hybrid-sdk-pbxproj-filetype branch May 19, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants