Conversation
|
constantinius
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
|
thanks @constantinius! I'm going to add the changeset |
There was a problem hiding this comment.
So pii: "maybe" means that a particular attribute is not scrubbed by default.
It also means that users can configure advanced data scrubbing rules so that scrubbing is run on those fields.
pii: "false" means that the scrubbing doesn't run AND the user won't be able to scrub it even with advanced rules.
So please let's use "false" only for IDs/enum values. For anything else that will contain dynamic content, we should use "maybe" at least, to give the user the possibility to scrub.
We should probably document this better so it's clear.
The rest looks good to me.
|
Fixed |
Adding MCP attributes.