Skip to content

feat(mcp): MCP attributes#171

Merged
betegon merged 9 commits intomainfrom
bete/feat/mcp-attributes
Oct 17, 2025
Merged

feat(mcp): MCP attributes#171
betegon merged 9 commits intomainfrom
bete/feat/mcp-attributes

Conversation

@betegon
Copy link
Member

@betegon betegon commented Oct 16, 2025

Adding MCP attributes.

@betegon betegon requested a review from constantinius October 16, 2025 10:42
@betegon betegon marked this pull request as ready for review October 16, 2025 10:42
@github-actions
Copy link

github-actions bot commented Oct 16, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d593223

@betegon betegon changed the title feat(mcp): Javascript MCP attributes feat(mcp): MCP attributes Oct 16, 2025
Copy link
Contributor

@constantinius constantinius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@betegon
Copy link
Member Author

betegon commented Oct 16, 2025

thanks @constantinius! I'm going to add the changeset

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So pii: "maybe" means that a particular attribute is not scrubbed by default.
It also means that users can configure advanced data scrubbing rules so that scrubbing is run on those fields.

pii: "false" means that the scrubbing doesn't run AND the user won't be able to scrub it even with advanced rules.

So please let's use "false" only for IDs/enum values. For anything else that will contain dynamic content, we should use "maybe" at least, to give the user the possibility to scrub.

We should probably document this better so it's clear.

The rest looks good to me.

@betegon betegon requested a review from lcian October 16, 2025 18:41
@betegon
Copy link
Member Author

betegon commented Oct 16, 2025

Fixed is_in_otel and PII false attributes, @lcian could you please have a quick look at it again?

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @betegon, looks good.

@betegon betegon merged commit 59296f4 into main Oct 17, 2025
7 checks passed
@betegon betegon deleted the bete/feat/mcp-attributes branch October 17, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants