feat: Add Culture context model attributes by logaretm · Pull Request #243 · getsentry/sentry-conventions

logaretm · 2026-02-04T16:51:15Z

Description

Add semantic conventions for the culture context, which captures localization and regional settings.

culture.calendar
culture.display_name
culture.locale
culture.is_24_hour_format
culture.timezone

PR Checklist

I have run yarn test and verified that the tests pass.
I have run yarn generate && yarn format to generate and format code and docs.

If an attribute was added:

The attribute is in a namespace (e.g: culture.timezone)
I have used the correct value for pii (We were sending those already so PII is false to all of them but happy to discuss and re-evaluate)

Related to getsentry/sentry-javascript#19148 and getsentry/relay#5615

github-actions · 2026-02-04T16:51:43Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

Attributes

Add sentry.profiler_id attribute by Lms24 in #242
Add attribute gen_ai.response.time_to_first_token by constantinius in #227
Add sentry.status_code attribute by mjq in #223
Backfill db.system attribute by mjq in #224
Add sentry.category attribute by mjq in #218
Add sentry.normalized_db_query.hash by Ahmed-Labs in #200

Other

(ai) Add input tokens cache write by shellmayr in #217
(gen_ai) Add new Gen AI attributes by obostjancic in #221

Add Culture context model attributes by logaretm in #243

Better docs website by Lms24 in #238
Add page listing all attributes by Lms24 in #207

Bug Fixes 🐛

Attributes

Migrating several numeric fields to pii=maybe by constantinius in #228
Improve gen_ai.operation.name description by obostjancic in #225

Other

(db) Clarify db.query.text and db.query.summary attributes by Lms24 in #208

Documentation 📚

Link to individual attributes by Lms24 in #248
Add links to llms.txt files by Lms24 in #247
Add toggleable dark and light mode by Lms24 in #246
Use proper svelte 5 syntax in search modal by Lms24 in #244
Add llms.txt for full list of attributes by Lms24 in #245

Internal Changes 🔧

Attributes

Update sentry.span.source with known values by Lms24 in #214
Add legacy attribute definitions for transaction spans by Ahmed-Labs in #212
Normalize deprecated db attribute names by Ahmed-Labs in #199

Deps Dev

Bump tar from 7.5.4 to 7.5.7 by dependabot in #239
Bump tar from 7.5.3 to 7.5.4 by dependabot in #226
Bump tar from 7.4.3 to 7.5.3 by dependabot in #220

Repo

Add Claude Code settings with basic permissions by philipphofmann in #222
Unstale yarn lock by Lms24 in #215

Other

(ai) Remove gen_ai_usage_total_cost attribute by vgrozdanic in #206
(lint) Don't lint Claude's config files by mjq in #219
(release) Switch from action-prepare-release to Craft by BYK in #216
Add statuses permission to Changelog Preview by lcian in #232

Other

Add more CODEOWNERS by cleptric in #240
Add @getsentry/ingest to CODEOWNERS by cleptric in #236
Update CODEOWNERS to change global ownership by cleptric in #230

_{🤖 This preview updates automatically when you update the PR.}

Copilot

Pull request overview

This PR adds semantic conventions for the culture context, which captures localization and regional settings. The changes introduce 5 new culture-related attributes that align with Sentry's culture context specification.

Changes:

Added 5 new culture attributes: culture.calendar, culture.display_name, culture.locale, culture.is_24_hour_format, and culture.timezone
Generated corresponding code in Python and JavaScript/TypeScript libraries
Updated documentation to include the new culture attributes namespace

Reviewed changes

Copilot reviewed 7 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
model/attributes/culture/culture__calendar.json	Defines the calendar system attribute
model/attributes/culture/culture__display_name.json	Defines the human-readable culture name attribute
model/attributes/culture/culture__is_24_hour_format.json	Defines the 24-hour time format preference attribute
model/attributes/culture/culture__locale.json	Defines the locale identifier attribute
model/attributes/culture/culture__timezone.json	Defines the timezone attribute
python/src/sentry_conventions/attributes.py	Adds culture attributes to Python library with proper alphabetical ordering
javascript/sentry-conventions/src/attributes.ts	Adds culture attributes to JavaScript/TypeScript library with proper alphabetical ordering
generated/attributes/index.md	Adds culture namespace to attribute index
generated/attributes/culture.md	Generated documentation for culture attributes
generated/attributes/all.md	Updates the total attribute count and includes culture attributes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T16:55:24Z

model/attributes/culture/culture__locale.json

@@ -0,0 +1,10 @@
+{
+  "key": "culture.locale",
+  "brief": "The locale identifier following RFC 4646.",


The reference to RFC 4646 is outdated. RFC 4646 was obsoleted by RFC 5646 in 2009. The brief description should reference RFC 5646 or BCP 47 instead, which is the current standard for language tags. The example "en-US" correctly follows this standard.

Suggested change

"brief": "The locale identifier following RFC 4646.",

"brief": "The locale identifier following BCP 47 (RFC 5646).",

Lms24

I would classify all of these attributes as pii: 'maybe'. Not because they strictly contain PII but because setting maybe allows users to define scrubbing rules in Relay (AFAIK).

Lms24 · 2026-02-05T11:15:20Z

model/attributes/culture/culture__locale.json

OTel defines browser.language which we could use instead.

That being said, scoping a value of sentry's culture context to browser isn't a great global strategy so I think we can just add this attribute as well for all SDKs. For the browser SDK, we could consider double-writing.

I wasn't sure how to classify them, but makes sense. I will update that in rely definitions as well.

For OTEL's browser.language, does that block this PR or does it need a re-thinking in terms of including this whole context?

No blocker from my PoV, just a thought!

Lms24

One more request, otherwise LGTM otherwise from my end

Lms24 · 2026-02-05T15:29:50Z

generated/attributes/all.md

let's remove the markdown files. We no longer need them after merging the docs website (#238)

If you rerun yarn:generate after rebaseing, these files shouldn't be generated anymore. Let me know in case they still show up.

Weird, I did re-run them and it generated them again. I removed them anyways!

logaretm requested a review from Lms24 as a code owner February 4, 2026 16:51

Copilot AI review requested due to automatic review settings February 4, 2026 16:51

logaretm requested review from a team, cleptric, lcian, mjq and nsdeschenes as code owners February 4, 2026 16:51

logaretm changed the title ~~feat: add culture model attributes~~ feat: Add culture model attributes Feb 4, 2026

Copilot started reviewing on behalf of logaretm February 4, 2026 16:51 View session

logaretm changed the title ~~feat: Add culture model attributes~~ feat: Add Culture context model attributes Feb 4, 2026

Copilot AI reviewed Feb 4, 2026

View reviewed changes

Lms24 reviewed Feb 5, 2026

View reviewed changes

logaretm force-pushed the awad/add-culture-attributes branch from e21d899 to f1b1b42 Compare February 5, 2026 14:20

logaretm requested a review from Lms24 February 5, 2026 14:29

Lms24 reviewed Feb 5, 2026

View reviewed changes

logaretm added 4 commits February 5, 2026 11:04

feat: add culture model attributes

ba07407

chore: generate files

77bfcf9

fix: define PII as maybe

8607027

chore: delete the generated files

ca8f3fb

logaretm force-pushed the awad/add-culture-attributes branch from f1b1b42 to ca8f3fb Compare February 5, 2026 16:05

	"brief": "The locale identifier following RFC 4646.",
	"brief": "The locale identifier following BCP 47 (RFC 5646).",

Uh oh!

Conversation

logaretm commented Feb 4, 2026

Description

PR Checklist

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Attributes

Other

Bug Fixes 🐛

Attributes

Other

Documentation 📚

Internal Changes 🔧

Attributes

Deps Dev

Repo

Other

Other

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Lms24 Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logaretm Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Lms24 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Lms24 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

logaretm Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Feb 4, 2026 •

edited

Loading

Lms24 Feb 5, 2026 •

edited

Loading