feat(attributes): Add middleware.name attribute#337
Open
ericapisani wants to merge 2 commits intomainfrom
Open
feat(attributes): Add middleware.name attribute#337ericapisani wants to merge 2 commits intomainfrom
ericapisani wants to merge 2 commits intomainfrom
Conversation
Add a new span attribute for capturing the name of a Starlette middleware in the Python SDK. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
ericapisani
requested review from
a team,
Lms24,
cleptric,
lcian,
mjq and
nsdeschenes
as code owners
cleptric
approved these changes
Apr 24, 2026
Rename the attribute to be framework-agnostic so it can be reused by other middleware instrumentations beyond Starlette. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ericapisani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new span attribute
middleware.namefor capturing the name of middlewares, client or server side.Refs PY-2362