feat(attributes): Add sentry.profile_id#344
Merged
loewenheim merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
| [SENTRY_ORIGIN]: 'string', | ||
| [SENTRY_PLATFORM]: 'string', | ||
| [SENTRY_PROFILER_ID]: 'string', | ||
| [SENTRY_PROFILE_ID]: 'string', |
There was a problem hiding this comment.
Bug: The SENTRY_PROFILE_ID attribute is not in alphabetical order in the generated TypeScript file, which is inconsistent with the Python implementation.
Severity: LOW
Suggested Fix
Reorder the SENTRY_PROFILE_ID and SENTRY_PROFILER_ID entries in the TypeScript attribute definitions, specifically in the ATTRIBUTE_TYPE map and the AttributeName union, to match the alphabetical order seen in the Python code.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: javascript/sentry-conventions/src/attributes.ts#L12168
Potential issue: In the generated TypeScript file `attributes.ts`, the
`SENTRY_PROFILE_ID` attribute is listed after `SENTRY_PROFILER_ID`. This violates the
alphabetical ordering convention that is followed in the corresponding Python
implementation. While this ordering discrepancy does not affect runtime functionality or
cause crashes, it introduces an inconsistency between the TypeScript and Python
codebases. This can negatively impact code readability and future maintenance.
Also affects:
javascript/sentry-conventions/src/attributes.ts:12726~12726javascript/sentry-conventions/src/attributes.ts:20108~20108
Did we get this right? 👍 / 👎 to inform future reviews.
tobias-wilfert
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This attribute was removed in #256, but Relay writes it for V2 spans that are converted from V1 spans.
Fixes getsentry/relay#5904. Fixes RELAY-233.
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)