feat(attributes): Add gcp.function.context.* span attributes#371
Merged
Conversation
Add GCP Cloud Function context attributes: type, source, id, specversion, time, eventId, timestamp, eventType, and resource. Needed by the JS SDK (JS-2221) for span streaming. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛Attributes
Other
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Rename gcp.function.context.eventId to event_id and eventType to event_type to comply with the repo's snake_case naming policy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chargome
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
loewenheim
approved these changes
May 18, 2026
Distinguish CloudEvents (2nd gen) id from legacy (1st gen) event_id to avoid ambiguity for downstream SDK developers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Lms24
approved these changes
May 18, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
The naming and attributes themselves LGTM. Though seems like we still need to fix all PR id references in the changelog sections.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type,source,id,specversion,time,eventId,timestamp,eventType,resourceeventId,eventType, andtimestampuse camelCase to match the GCP API field names