chore(publish): Automatically add PR numbers to attribute changelogs#402
Draft
Lms24 wants to merge 1 commit into
Draft
chore(publish): Automatically add PR numbers to attribute changelogs#402Lms24 wants to merge 1 commit into
Lms24 wants to merge 1 commit into
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #401 (comment), it would be helpful to automatically add PR numbers to the
prsarray of attribute changelogs at release time. This PR reuses the PR extraction logic from the manual changelog population script to apply it to all attributes with a "next" changelog entry that gets converted to the new version via the pre-release script.This means, we don't have to manually reference PRs when making changes/adding attributes to conventions.