feat: Add missing GCP and FaaS attributes#403
Conversation
Add faas.duration_in_ms, faas.entry_point, faas.identity, and gcp.project.id to the model and regenerate JS and Python attribute files.
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Docs
Other
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Reading the slack thread, we should also add the current attributes (sent by the SDK in transaction mode) as deprecated attributes into conventions and mark them as replaced by the new ones. Feel free to do this in a follow-up PR if you prefer!
This allows us to do backwards/forwards coalescing at ingest/query time so that existing dashboards/queries/alerts remain functional.
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 39754ca. Configure here.
Correct me if I'm wrong, but in this case I don't think there's any attributes to mark as deprecated because these values are being sent as part of the |
…m:getsentry/sentry-conventions into py-2324-introduce-missing-gcp-conventions
The source JSON attribute definitions were updated to reflect new OTEL mappings, particularly for FaaS attributes. Regenerate the TypeScript and Python attribute files to match these changes. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
@ericapisani you're right, sorry, I didn't know they weren't sent as |
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "key": "gcp.project.id", | |||
There was a problem hiding this comment.
I double-checked and we currently send a cloud.project_id attribute in JS that's only applied to GCP. I agree with your reasoning though to scope this attribute to the gcp namespace. Makes much more sense, given the other FAAS providers don't have the same project semantics as GCP.
Once this PR is merged, I'll open a PR to add the attribute from JS and deprecate it in favour of this one.

Add faas.duration_in_ms, faas.entry_point, faas.identity, and gcp.project.id to the model and regenerate JS and Python attribute files.
These attributes were missing from the conventions despite being used in GCP and FaaS instrumentation. Adding them ensures SDKs have consistent, typed constants to reference rather than relying on raw strings.