Skip to content

docs: Remove semicolon in db.query.summary example#439

Merged
JPeer264 merged 1 commit into
mainfrom
jp/remove-comma
Jun 19, 2026
Merged

docs: Remove semicolon in db.query.summary example#439
JPeer264 merged 1 commit into
mainfrom
jp/remove-comma

Conversation

@JPeer264

Copy link
Copy Markdown
Member

Description

I was going over the db.query.* examples and saw that the ; should not be there in db.query.summary this also reflects the conventions: https://opentelemetry.io/docs/specs/semconv/db/sql/ (it is just a little tough to see, as there is a ;, but it is not part of the example)

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@JPeer264 JPeer264 self-assigned this Jun 19, 2026
@JPeer264 JPeer264 requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners June 19, 2026 09:26
@github-actions

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (docs) Make span name and description cards linkable by Lms24 in #433

Documentation 📚

  • (contributing) Improve releasing and downstream update instructions by constantinius in #434
  • Remove semicolon in db.query.summary example by JPeer264 in #439

Internal Changes 🔧

  • (attributes) Rename pii field to apply_scrubbing by cleptric in #426
  • (deps) Bump astro from 6.1.10 to 6.4.6 in /docs by dependabot in #432
  • Update yarn.lock file by JPeer264 in #436
  • Bump all dependencies to fix esbuild security issues by cleptric in #431

Other

  • Update blame ignore revs for pii field renaming by cleptric in #437

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Honestly, I had to look 3 times at the OTel docs to grasp that the semicolon isn't part of the examples, even after you called it out lol

@JPeer264 JPeer264 merged commit 544ed93 into main Jun 19, 2026
15 checks passed
@JPeer264 JPeer264 deleted the jp/remove-comma branch June 19, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants