Fix SDK names in the native SDKs #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Mar 9, 2023
marandaneto
commented
Mar 9, 2023
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1320 +/- ##
=======================================
Coverage 90.41% 90.41%
=======================================
Files 168 168
Lines 5246 5246
=======================================
Hits 4743 4743
Misses 503 503
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@bruno-garcia can you double-check if the SDK names are matching your spec? |
Member
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
The names make sense to me: basically appending just .flutter 👌
brustolin
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Change SDK names of the Native SDKs when embedded in a Hybrid SDK.
#skip-changelog
💡 Motivation and Context
Fix #1185
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps