-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: override sdk name and version #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...droidMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryAndroidOptionsExtensions.kt
Outdated
Show resolved
Hide resolved
.../commonAppleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryOptionsExtensions.kt
Outdated
Show resolved
Hide resolved
.../commonAppleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryOptionsExtensions.kt
Outdated
Show resolved
Hide resolved
...ltiplatform/src/commonAppleMain/kotlin/io/sentry/kotlin/multiplatform/protocol/SdkVersion.kt
Outdated
Show resolved
Hide resolved
...ltiplatform/src/commonAppleMain/kotlin/io/sentry/kotlin/multiplatform/protocol/SdkVersion.kt
Outdated
Show resolved
Hide resolved
...y-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryOptions.kt
Outdated
Show resolved
Hide resolved
.../commonAppleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryOptionsExtensions.kt
Show resolved
Hide resolved
marandaneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments but other than that LGTM
|
@marandaneto I was thinking about adding event.origin and event.environment tags as well like in flutter and react-native: would that make sense here as well? |
Nope because of getsentry/team-mobile#60 |
|
@buenaflor after double-checking this on Flutter and RN. |
Overrides the sdk name and version in the specific SDKs
example:
sdk name:
sentry.kotlin.kmpsdk version:
0.0.1(currently)packages depending on which platform the user uses:
jvm:
android:
apple:
LMK if some naming is incorrect
Testing:
The sentry events now show the specified sdk name and version at the bottom. Also tested it by temporarily modifying a Look on Looker: