Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Mar 3, 2023

Overrides the sdk name and version in the specific SDKs

example:
sdk name: sentry.kotlin.kmp
sdk version: 0.0.1 (currently)

packages depending on which platform the user uses:
jvm:

  • `name: "maven:io.sentry:sentry", version: "6.14.0"

android:

  • `name: "maven:io.sentry:sentry-android", version: "6.14.0"

apple:

  • `name: "cocoapods:sentry-cocoa", version: "8.2.0"

LMK if some naming is incorrect

Testing:
The sentry events now show the specified sdk name and version at the bottom. Also tested it by temporarily modifying a Look on Looker:

Screenshot 2023-03-06 at 09 43 58

@buenaflor buenaflor marked this pull request as ready for review March 6, 2023 09:33
@buenaflor buenaflor requested a review from marandaneto March 6, 2023 09:33
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments but other than that LGTM

@buenaflor
Copy link
Contributor Author

buenaflor commented Mar 7, 2023

@marandaneto I was thinking about adding event.origin and event.environment tags as well like in flutter and react-native:

https://github.com/getsentry/sentry-dart/blob/11fb40841ad3d6fc46e02eb8adeb74d5b6932582/flutter/ios/Classes/SentryFlutterPluginApple.swift#L393

would that make sense here as well?

@marandaneto
Copy link
Contributor

@marandaneto I was thinking about adding event.origin and event.environment tags as well like in flutter and react-native:

getsentry/sentry-dart@11fb408/flutter/ios/Classes/SentryFlutterPluginApple.swift#L393

would that make sense here as well?

Nope because of getsentry/team-mobile#60
Also, I'd focus on shipping the current version.

@buenaflor buenaflor merged commit ddfbbee into main Mar 7, 2023
@buenaflor buenaflor deleted the feat/adoption branch March 7, 2023 14:26
@marandaneto
Copy link
Contributor

@buenaflor after double-checking this on Flutter and RN.
See my PR getsentry/sentry-dart#1320
The Native SDKs should just have .kmp at the end, and not replace the whole thing.
Can we fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants