-
-
Notifications
You must be signed in to change notification settings - Fork 278
Fix: Rename some protocol classes #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
| * Fix: Multiple FlutterError.onError calls in FlutterErrorIntegration (#345) | ||
| * Fix: Pass hint to EventProcessors (#356) | ||
| * Fix: EventProcessors were not dropping events when returning null (#353) | ||
| * Fix: Prefix App, Browser, Device, Message, Request and User with Sentry (#250) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Fix: Prefix App, Browser, Device, Message, Request and User with Sentry (#250) | |
| Breaking Changes: | |
| * Fix: Prefix App, Browser, Device, Message, Request and User with Sentry (#250) | |
| // let's describe here the renamed Protocols and that now they have a 'Sentry' prefix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll probably need to add a Migration page to https://docs.sentry.io/platforms/dart/ but let's track this in another issue :)
|
I guess |
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
bruno-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I wonder if we're going into 5.0.0 now?
Agree renaming these 3 could make sense. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 89.79% 89.80% +0.01%
==========================================
Files 51 51
Lines 1636 1638 +2
==========================================
+ Hits 1469 1471 +2
Misses 167 167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
let's do one more pre-release with the fixes we've done and if all good, we do a GA next. |
@ueman do you prefer to rename these 3 left on this PR or a new one? |
I've renamed them in this PR. |
|
For consistency, we could prefix all of them with Sentry. As a user, I can imagine, that you don't fully understand why some of them have the prefix and some of them don't. |
📜 Description
This is a breaking change.
This PR renames a couple classes:
I wonder if we should rename the following classes too:
The following classes are probably fine:
💡 Motivation and Context
See #250
💚 How did you test it?
No functional changes, tests are still green
📝 Checklist
🔮 Next steps
Update documentation: