Skip to content

Conversation

@ueman
Copy link
Contributor

@ueman ueman commented Mar 15, 2021

@vercel
Copy link

vercel bot commented Mar 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/diqJPPTx32iG9ZX2tysKFMCUNPwB
✅ Preview: https://sentry-docs-git-fork-ueman-patch-3.sentry.dev

@marandaneto
Copy link
Contributor

should merge only once v5 is GA

@marandaneto
Copy link
Contributor

marandaneto commented Mar 15, 2021

we'd need to do the migration page from v4 to v5 also on our docs, it could be something similar to what we've done for the changelog.
See #3196

See Android docs: https://docs.sentry.io/platforms/android/migration/#migrating-from-iosentrysentry-410-to-iosentrysentry-420

@marandaneto marandaneto marked this pull request as draft March 16, 2021 13:29
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
lets wait for v5 GA

@marandaneto
Copy link
Contributor

I've made it a draft to not accidentally merge it, its good to go though

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@marandaneto marandaneto marked this pull request as ready for review March 31, 2021 08:53
@marandaneto marandaneto enabled auto-merge (squash) March 31, 2021 08:53
@marandaneto marandaneto merged commit f0710ad into getsentry:master Mar 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2021
@ueman ueman deleted the patch-3 branch April 26, 2021 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants