Fix: Plugin registrant warning #358
Conversation
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 89.79% 89.79%
=======================================
Files 51 51
Lines 1636 1636
=======================================
Hits 1469 1469
Misses 167 167 Continue to review full report at Codecov.
|
| rules: | ||
| prefer_relative_imports: true | ||
| unnecessary_brace_in_string_interps: true | ||
| implementation_imports: true |
There was a problem hiding this comment.
currently, we're using package:pedantic, is there a more aggressive solution? often I see us enabling new rules that should be avoided in the 1st place :D (not for this PR though)
There was a problem hiding this comment.
As per https://dart-lang.github.io/linter/lints/ there are three official rule sets: pedantic, effective_dart and flutter.
There's also https://pub.dev/packages/lint which describes itself as very strict.
There was a problem hiding this comment.
thanks, I'll have a look at this one (lint) later this week.
CHANGELOG.md
Outdated
| * Fix: Multiple FlutterError.onError calls in FlutterErrorIntegration (#345) | ||
| * Fix: Pass hint to EventProcessors (#356) | ||
| * Fix: EventProcessors were not dropping events when returning null (#353) | ||
| * Fix: Plugin Registrant class moved to barrel file (#314) |
There was a problem hiding this comment.
by Danger, requires PRs id
theoretically, no as the import as code generated right, but technically yes, mmm, we could take the same approach as https://github.com/getsentry/sentry-dart/pull/357/files#r594101972 |
📜 Description
I moved the class
SentryFlutterWebfromsrc/sentry_flutter_web.darttosentry_flutter_web.dart.I also enabled this lint to prevent this kind of errors in
the future.
I'm not sure if this is considered a breaking change or not. Technically it is, because the imports changed I guess.
💡 Motivation and Context
See #314
💚 How did you test it?
I've enabled the lint and it didn't show any warnings.
📝 Checklist
🔮 Next steps