Skip to content

Fix: Plugin registrant warning #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fix: Plugin registrant warning #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d6a788
Fix: Plugin registrant warning
ueman Mar 15, 2021
a6a3e53
Improve changelog
ueman Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
* Fix: Pass hint to EventProcessors (#356)
* Fix: EventProcessors were not dropping events when returning null (#353)


## Breaking Changes:

* Fix: Plugin Registrant class moved to barrel file (#358)
* This changed the import from `import 'package:sentry_flutter/src/sentry_flutter_web.dart';`
to `import 'package:sentry_flutter/sentry_flutter_web.dart';`
* This could lead to breaking changes. Typically it shouldn't because the referencing file is auto-generated.

# 4.1.0-nullsafety.0

* Fix: Do not append stack trace to the exception if there are no frames
Expand Down
1 change: 1 addition & 0 deletions flutter/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ linter:
rules:
prefer_relative_imports: true
unnecessary_brace_in_string_interps: true
implementation_imports: true
Copy link
Contributor

@marandaneto marandaneto Mar 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, we're using package:pedantic, is there a more aggressive solution? often I see us enabling new rules that should be avoided in the 1st place :D (not for this PR though)

Copy link
Collaborator Author

@ueman ueman Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://dart-lang.github.io/linter/lints/ there are three official rule sets: pedantic, effective_dart and flutter.
There's also https://pub.dev/packages/lint which describes itself as very strict.

Copy link
Contributor

@marandaneto marandaneto Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'll have a look at this one (lint) later this week.

0 flutter/lib/src/sentry_flutter_web.dart → flutter/lib/sentry_flutter_web.dart
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ flutter:
pluginClass: SentryFlutterPlugin
web:
pluginClass: SentryFlutterWeb
fileName: src/sentry_flutter_web.dart
fileName: sentry_flutter_web.dart