Skip to content

Conversation

@chargome
Copy link
Member

@chargome chargome commented Aug 1, 2024

  • Applies custom search settings from sentry-global-search
  • Tags algolia records with their respective sdk and framework names for improving path bias (when searching from react guide, results will prioritise records within the guide)
  • Updates search settings for algolia client to include framework name for improving search results

relates to #10592

@chargome chargome self-assigned this Aug 1, 2024
@vercel
Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 4:16pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 4:16pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 4:16pm

@codecov
Copy link

codecov bot commented Aug 1, 2024

Bundle Report

Changes will increase total bundle size by 11 bytes ⬆️

Bundle name Size Change
sentry-docs-server 8.55MB 60 bytes ⬆️
sentry-docs-edge-server 255.88kB 3 bytes ⬇️
sentry-docs-client 6.24MB 46 bytes ⬇️

@a-hariti
Copy link
Collaborator

a-hariti commented Aug 1, 2024

Does it address this example from the mentioned issue by @mydea ?

Opentelementry search while on node platform

Copy link
Collaborator

@a-hariti a-hariti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea!

@chargome
Copy link
Member Author

chargome commented Aug 2, 2024

@a-hariti yes it does improve the search for that case. Generally speaking, the path bias makes search much more usable this way, but there is probably still room for improvement. Let's try to gather cases and improve incrementally I would say

@a-hariti
Copy link
Collaborator

a-hariti commented Aug 2, 2024

is this preview using test indices with tagged records?

@chargome
Copy link
Member Author

chargome commented Aug 2, 2024

No the preview is still running on the old index. You can only test that out with a local version of sentry-global-search

@a-hariti
Copy link
Collaborator

a-hariti commented Aug 2, 2024

I understand, so you can only test the ranking locally?

@chargome
Copy link
Member Author

chargome commented Aug 2, 2024

Yes, or through the dashboard on algolia

@chargome chargome merged commit 757bef6 into master Aug 5, 2024
@chargome chargome deleted the cg/fix-algolia-search branch August 5, 2024 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants