Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 2, 2024

This PR adds JavaScript SDK specific documentation to the develop docs. The idea of these docs is that everyone at Sentry, as well as external community contributors can read up on certain aspects of the JS SDKs that are good to know.

These docs do not replace general SDK specifications or documentation in the JS SDK repo. It's meant as additional documentation.

For starters, this PR adds docs on:

  • Why bundle size is important in the browser SDK
  • How tracing works in the browser SDK, including a description of pageload and navigation spans

@vercel
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 8:37am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 8:37am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 8:37am

@Lms24 Lms24 self-assigned this Aug 2, 2024
@Lms24 Lms24 marked this pull request as ready for review August 2, 2024 14:07
@Lms24 Lms24 requested review from a team, andreiborza, chargome, s1gr1d and stephanie-anderson and removed request for a team August 2, 2024 14:07
@Lms24 Lms24 changed the title feat(sdks): Add section with JS SDK-specific information feat(develop/sdks): Add section with JS SDK-specific information Aug 2, 2024
@Lms24 Lms24 requested a review from mydea August 2, 2024 14:29
Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
Lms24 and others added 2 commits August 5, 2024 09:49
Co-authored-by: Sigrid Huemer <32902192+s1gr1d@users.noreply.github.com>
Co-authored-by: Nicolas Hrubec <nicolas.hrubec@outlook.com>
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the changes 🙌🏻

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work on this!

@Lms24 Lms24 merged commit b52eca8 into master Aug 5, 2024
@Lms24 Lms24 deleted the lms/feat-develop-js-sdk-docs branch August 5, 2024 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants