Skip to content

Conversation

@jjbayer
Copy link
Member

@jjbayer jjbayer commented Sep 27, 2024

Link to rendered page: https://develop-docs-git-feat-ds-outcomes.sentry.dev/application/dynamic-sampling/outcomes/

DESCRIBE YOUR PR

Document why & how some data types report outcomes in two different categories.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 7:53am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 7:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 7:53am

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jjbayer , I added some minor edit suggestions, besides that, looks good!

Co-authored-by: Alex Krawiec <alexanderkrawiec@gmail.com>
@jjbayer jjbayer enabled auto-merge (squash) October 3, 2024 07:48
@jjbayer jjbayer merged commit 8b8b9f2 into master Oct 3, 2024
9 checks passed
@jjbayer jjbayer deleted the feat/ds-outcomes branch October 3, 2024 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants