Skip to content

Conversation

@philipphofmann
Copy link
Member

DESCRIBE YOUR PR

Explain that some crashes might lead to watchdog termination events.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Explain that some crashes might lead to watchdog termination events.
@philipphofmann philipphofmann requested a review from a team September 30, 2024 13:24
@vercel
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog 🛑 Canceled (Inspect) Oct 3, 2024 0:39am
sentry-docs 🛑 Canceled (Inspect) Oct 3, 2024 0:39am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 0:39am

@codecov
Copy link

codecov bot commented Sep 30, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.45MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.42MB 6 bytes (-0.0%) ⬇️

…s.mdx

Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Copy link
Contributor

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the additional clarification 🙏

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggested edits, overall LGTM! 👍

philipphofmann and others added 6 commits October 3, 2024 14:06
…s.mdx

Co-authored-by: Alex Krawiec <alexanderkrawiec@gmail.com>
…s.mdx

Co-authored-by: Alex Krawiec <alexanderkrawiec@gmail.com>
…s.mdx

Co-authored-by: Alex Krawiec <alexanderkrawiec@gmail.com>
…s.mdx

Co-authored-by: Alex Krawiec <alexanderkrawiec@gmail.com>
…s.mdx

Co-authored-by: Alex Krawiec <alexanderkrawiec@gmail.com>
…s.mdx

Co-authored-by: Alex Krawiec <alexanderkrawiec@gmail.com>
@philipphofmann philipphofmann enabled auto-merge (squash) October 3, 2024 12:09
@philipphofmann philipphofmann merged commit 6355dae into master Oct 3, 2024
10 checks passed
@philipphofmann philipphofmann deleted the fix/watchdog-termination-reasons branch October 3, 2024 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants