Skip to content

Conversation

@hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Oct 1, 2024

DESCRIBE YOUR PR

*This moves some self-hosted pages to an experimental section to boldly indicate that these features are not well supported

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:47pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:47pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 11:47pm

Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also move Geolocation under this section, it's not a core feature, and it's not trivial to set up (and maintain) correctly.

Same thing with Content Security Policy? It has a This is an experimental feature. Use it with caution. banner already.

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Oct 1, 2024

I think we should also move Geolocation under this section, it's not a core feature, and it's not trivial to set up (and maintain) correctly.

This ships with self-hosted and has been around forever, so I don't think it is necessarily experimental anymore given that I believe sentry uses this. Good call on CSP.

@hubertdeng123 hubertdeng123 merged commit 5c9cf4a into master Oct 1, 2024
9 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-experimental-page-self-hosted branch October 1, 2024 23:50
@aldy505
Copy link
Collaborator

aldy505 commented Oct 2, 2024

Since you made this, can I put some more obscure stuff inside?

@hubertdeng123
Copy link
Member Author

@aldy505 depends on what kind of stuff, what are you thinking?

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants