Skip to content

docs(bottle): Document failed_request_status_codes #11515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2024
Merged

docs(bottle): Document failed_request_status_codes #11515

merged 2 commits into from
Oct 14, 2024

Conversation

@szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Oct 8, 2024 •
edited
Loading

DESCRIBE YOUR PR

Document Bottle integration's failed_request_status_codes option, added in #3618.

IS YOUR CHANGE URGENT?

  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@szokeasaurusrex szokeasaurusrex requested review from a team, antonpirker and sentrivana October 8, 2024 14:55
@vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 9:06am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 9:06am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 9:06am

@codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 6 bytes (-0.0%) ⬇️

coolguyzone
coolguyzone reviewed Oct 9, 2024
View reviewed changes
coolguyzone
coolguyzone reviewed Oct 9, 2024
View reviewed changes
coolguyzone
coolguyzone reviewed Oct 9, 2024
View reviewed changes
coolguyzone
coolguyzone approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! Left a couple of minor suggestions, looks good to me!

@szokeasaurusrex szokeasaurusrex mentioned this pull request Oct 11, 2024
Merged
4 tasks
Base automatically changed from szokeasaurusrex/bottle-options to master October 14, 2024 08:30
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/bottle-failed_request_status_codes branch from dcb9e61 to 19f60de Compare October 14, 2024 08:31
@szokeasaurusrex szokeasaurusrex merged commit 8619b36 into master Oct 14, 2024
11 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/bottle-failed_request_status_codes branch October 14, 2024 13:37
@szokeasaurusrex szokeasaurusrex linked an issue Oct 15, 2024 that may be closed by this pull request
Document Bottle failed_request_status_codes #11509
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@coolguyzone coolguyzone coolguyzone approved these changes

@sentrivana sentrivana sentrivana approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document Bottle failed_request_status_codes

4 participants

@szokeasaurusrex @coolguyzone @sentrivana