Skip to content

Conversation

@chargome
Copy link
Member

@chargome chargome commented Oct 9, 2024

Incorrectly nested <tr> elements as direct children of <table> cause hydration errors as <tbody> elements get injected by the browser.

@vercel
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 8:58am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 8:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Oct 9, 2024 8:58am

@chargome chargome requested a review from ryan953 October 9, 2024 08:44
@chargome chargome self-assigned this Oct 9, 2024
@codecov
Copy link

codecov bot commented Oct 9, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know 100"% that react will inject missing tags like this.

Lmk how the experience is to find each cause and get a PR out like this wrt the hydration issue in sentry!

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tables look fine in preview. Adding the <tbody> tags should help with accessibility as well as the rendering errors 👍

@chargome chargome merged commit 156dc1a into master Oct 10, 2024
10 checks passed
@chargome chargome deleted the cg/more-hydration-errors branch October 10, 2024 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants