Feat(apple): Cocoa direct install #11539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 192 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Thanks for adding this. I have a few questions.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
philipphofmann
approved these changes
Oct 11, 2024
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
A few more minor things to fix, but LGTM.
| @@ -0,0 +1,18 @@ | |||
| --- | |||
| title: Manual Install | |||
Member
There was a problem hiding this comment.
m: We should also rename the file to manual-install.mdx to align.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Explaining how to use cocoa pre-compiled frameworks