feat(relay): Add document describing span and transaction quotas #11563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dav1dde
force-pushed
the
dav1d/transaction-span-outcomes
branch
from
e882eac to
fc3c7eb
Compare
jan-auer
reviewed
Oct 17, 2024
Comment on lines
+70
to
+72
| While it is desirable to have span counts correctly extracted from dropped transactions, it may not be feasible | ||
| to do so at any stage of the processing pipeline. For example, it may not be possible to do so (malformed transactions) | ||
| or simply too expensive to compute. |
There was a problem hiding this comment.
Out of scope for this PR: I brought this up with the SDK teams in the past week and we can add metadata to Envelopes that allows us to emit proper outcomes in this scenario, assuming the client submits correct values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Description of how span and transaction outcomes are (to be) handled within Relay.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: