Skip to content

Conversation

@Bogdanp
Copy link
Contributor

@Bogdanp Bogdanp commented Oct 20, 2024

DESCRIBE YOUR PR

Fixes some bad markdown in a document.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 20, 2024

@Bogdanp is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 4:01am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 4:01am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 4:01am

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing this. Verified in Vercel preview, good to merge.

@Bogdanp
Copy link
Contributor Author

Bogdanp commented Nov 10, 2024

I was just checking my open PRs and was surprised to see this was still open. Any reason not to merge it?

@coolguyzone coolguyzone merged commit 849302d into getsentry:master Nov 11, 2024
11 checks passed
@coolguyzone
Copy link
Contributor

This one fell through the cracks, merged!

@Bogdanp Bogdanp deleted the patch-1 branch November 11, 2024 16:33
vaind pushed a commit that referenced this pull request Nov 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants