Skip to content

Conversation

@armcknight
Copy link
Member

@armcknight armcknight commented Nov 7, 2024

DESCRIBE YOUR PR

Updating apple docs for continuous profiling.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): Nov 18
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:18pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:18pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:18pm

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Nov 19, 2024

Bundle Report

Changes will increase total bundle size by 14.16MB (79.22%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
sentry-docs-server* 7.46MB 7.46MB (100%) ⬆️⚠️
sentry-docs-edge-server* 254.44kB 254.44kB (100%) ⬆️⚠️
sentry-docs-client* 6.38MB 6.38MB (100%) ⬆️⚠️
sentry-docs-server-cjs 8.67MB 69.64kB (0.81%) ⬆️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

@armcknight armcknight merged commit 9e179d4 into master Nov 20, 2024
11 checks passed
@armcknight armcknight deleted the armcknight/feat/continuous-profiling branch November 20, 2024 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants