feat(apple): Explain UIViewController scope logic #11816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain how the SDK decides on the parent-child relationship for UIViewController transactions and which UIViewController transactions to put on the scope.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
brustolin
approved these changes
Nov 14, 2024
lizokm
approved these changes
Nov 14, 2024
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Restructured the wording a bit. Let me know if anything doesn't sound right or make sense.
docs/platforms/apple/common/tracing/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
…instrumentation.mdx Co-authored-by: Liza Mock <liza.mock@sentry.io>
Member
Author
|
Way better, thanks, @lizokm 🥳 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Explain how the SDK decides on the parent-child relationship for UIViewController transactions and which UIViewController transactions to put on the scope.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: