Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

DESCRIBE YOUR PR

Removing Metrics documentation now this feature has been deprecated

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • [ x ] None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.

@bruno-garcia you're the only person that I can assign as a reviewer on this sorry... I can't select Bryce in this repo.

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Nov 19, 2024

@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@jamescrosswell
Copy link
Collaborator Author

I see, the linting error implies this can't be removed for .NET in isolation (it would need to be removed for all the other platforms as well presumably?):

❌ Found 1 404 across 1 page

🌐 http://localhost:3000/product/explore/metrics/metrics-set-up
    - [.NET](/platforms/dotnet/metrics/)

@vercel
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 10:43am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 10:43am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 10:43am

@coolguyzone
Copy link
Contributor

@bitsandfoxes can you take a look?

bitsandfoxes
bitsandfoxes previously approved these changes Nov 21, 2024
@bitsandfoxes bitsandfoxes dismissed their stale review November 21, 2024 12:26

Missed the 404

@bitsandfoxes
Copy link
Contributor

We can also remove the reference to the deleted page here

- [.NET](/platforms/dotnet/metrics/)

@jamescrosswell
Copy link
Collaborator Author

We can also remove the reference to the deleted page here

- [.NET](/platforms/dotnet/metrics/)

Yeah I assumed that was the language agnostic docs though so would affect all the SDKs (not just the .NET SDK)... and I didn't want to mess with that.

@bitsandfoxes
Copy link
Contributor

I think it's fine to remove the entry on the product page as it links specifically to the page that' getting removed.

@jamescrosswell
Copy link
Collaborator Author

I think it's fine to remove the entry on the product page as it links specifically to the page that' getting removed.

Ah I see.. there's a link per platform. Thanks @bitsandfoxes

@bitsandfoxes bitsandfoxes merged commit fd1a3f9 into getsentry:master Nov 25, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants