Skip to content

Conversation

@antonpirker
Copy link
Contributor

DESCRIBE YOUR PR

The "Configuration" page did not make sense in Application Architecture, because it documentas the configuration options one can set for the API server.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 10:27am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 10:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Dec 2, 2024 10:27am

@antonpirker antonpirker marked this pull request as ready for review December 2, 2024 10:14
@codecov
Copy link

codecov bot commented Dec 2, 2024

Bundle Report

Changes will increase total bundle size by 11 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.2MB 51 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 363.92kB 68 bytes (0.02%) ⬆️
sentry-docs-client-array-push 9.11MB 6 bytes (-0.0%) ⬇️

@antonpirker antonpirker enabled auto-merge (squash) December 2, 2024 10:22
@antonpirker antonpirker merged commit 60dc8bb into master Dec 2, 2024
13 checks passed
@antonpirker antonpirker deleted the antonpirker/develop/moved-config-in-sidebar branch December 2, 2024 10:27
aliu39 pushed a commit that referenced this pull request Dec 2, 2024
The "Configuration" page did not make sense in Application Architecture, because it documentas the configuration options one can set for the API server.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants