Skip to content

Conversation

@coolguyzone
Copy link
Contributor

@coolguyzone coolguyzone commented Dec 2, 2024

DESCRIBE YOUR PR

Create a platform-agnostic page to explain the various sample rate options available with Sentry.

See preview on: https://sentry-docs-git-sample-rate-concept.sentry.dev/concepts/key-terms/sample-rates/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 7:22pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 7:22pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 7:22pm

@codecov
Copy link

codecov bot commented Dec 2, 2024

Bundle Report

Changes will increase total bundle size by 150 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.13MB 156 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.02MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good!

I'd love for this doc to have a bit more additional info for people who are coming to this page without knowing a lot about Sentry :)

coolguyzone and others added 3 commits December 2, 2024 16:02
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for adding. I think it will be a big help.

coolguyzone and others added 4 commits December 3, 2024 11:08
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@coolguyzone coolguyzone enabled auto-merge (squash) December 3, 2024 19:10
pull bot pushed a commit to zxc00o/sentry-docs that referenced this pull request Dec 3, 2024
* Refactor sample rates page to be more specific

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Add an overview of sample rates

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

---------

Co-authored-by: Alex Krawiec <alex.krawiec@R7J1Y747QQ.local>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
pull bot pushed a commit to zxc00o/sentry-docs that referenced this pull request Dec 3, 2024
* Refactor sample rates page to be more specific

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Add an overview of sample rates

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

---------

Co-authored-by: Alex Krawiec <alex.krawiec@R7J1Y747QQ.local>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@coolguyzone coolguyzone disabled auto-merge December 3, 2024 21:25
@coolguyzone coolguyzone merged commit 91f50d6 into master Dec 3, 2024
11 checks passed
@coolguyzone coolguyzone deleted the sample-rate-concept branch December 3, 2024 21:25
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
* Refactor sample rates page to be more specific

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Add an overview of sample rates

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

---------

Co-authored-by: Alex Krawiec <alex.krawiec@R7J1Y747QQ.local>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
* Refactor sample rates page to be more specific

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Add an overview of sample rates

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

---------

Co-authored-by: Alex Krawiec <alex.krawiec@R7J1Y747QQ.local>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
* Refactor sample rates page to be more specific

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Add an overview of sample rates

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/concepts/key-terms/sample-rates.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

---------

Co-authored-by: Alex Krawiec <alex.krawiec@R7J1Y747QQ.local>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants