feat: Scrubbing HTTP Data from Breadcrumbs #12025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain that most SDKs will add the HTTP query string and fragment as a data attribute to breadcrumbs.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6 tasks
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
coolguyzone
approved these changes
Dec 4, 2024
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Thanks for updating, LGTM! 💪
Lms24
pushed a commit
that referenced
this pull request
Dec 13, 2024
Explain that most SDKs will add the HTTP query string and fragment as a data attribute to breadcrumbs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Explain that most SDKs will add the HTTP query string and fragment as a data attribute to breadcrumbs, which is recommended in the develop docs.
This section is duplicated for all SDKs, so I updated it for all that have the following section:
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: