Update micro-frontends.mdx #12040
Merged
Update micro-frontends.mdx #12040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update micro frontend docs based on user feedback.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 2.53kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
lizokm
commented
Dec 4, 2024
docs/platforms/javascript/common/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
6 tasks
Lms24
approved these changes
Dec 4, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for updating this page! I left some suggestions/questions but it's definitely an improvement. If you're okay with it, let's merge this in first and then I'll merge in #12023 and add a link from the top-most warning in this PR to my additional section on the bottom.
docs/platforms/javascript/common/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
reviewed
Dec 4, 2024
docs/platforms/javascript/common/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
…s.mdx Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
…s.mdx Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
…s.mdx Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
lizokm
commented
Dec 5, 2024
docs/platforms/javascript/common/best-practices/micro-frontends.mdx
Outdated
Show resolved
Hide resolved
Lms24
added a commit
that referenced
this pull request
Dec 13, 2024
* Update micro-frontends.mdx Update micro frontend docs based on user feedback. * Update docs/platforms/javascript/common/best-practices/micro-frontends.mdx * Update docs/platforms/javascript/common/best-practices/micro-frontends.mdx * Update docs/platforms/javascript/common/best-practices/micro-frontends.mdx * Update docs/platforms/javascript/common/best-practices/micro-frontends.mdx * Update docs/platforms/javascript/common/best-practices/micro-frontends.mdx Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io> * Update docs/platforms/javascript/common/best-practices/micro-frontends.mdx Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io> * Update docs/platforms/javascript/common/best-practices/micro-frontends.mdx Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io> * Update docs/platforms/javascript/common/best-practices/micro-frontends.mdx --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io> Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update micro frontend docs based on user feedback.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES