Skip to content

Conversation

@drguthals
Copy link
Contributor

DESCRIBE YOUR PR

In support of a blog post coming out, we realized we're missing a more detailed explanation of what is available for each package version of the Unreal SDK. This should add that detail.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: This is urgent for V0 because we want to get the blog post published
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs 🛑 Canceled (Inspect) Dec 10, 2024 6:40pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 6:40pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 6:40pm

@codecov
Copy link

codecov bot commented Dec 9, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you Sarah!

There are three common ways to install an SDK to use with Unreal Engine:
1. Install from the [Epic Games Fab](https://www.fab.com/) ([formerly known as the marketplace](https://www.unrealengine.com/en-US/blog/fab-epics-new-unified-content-marketplace-launches-today))
2. Download a pre-built SDK that you install (e.g. from a [GitHub Releases page](https://github.com/getsentry/sentry-unreal/releases))
3. Clone and build the SDK yourself and install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This will come in handy soon since we're working on improving our build so users can build our SDK using U reals build system.

| Supported UE project types | Blueprint and C++ | C++ only | C++ only |
| Backend (Windows) | Breakpad | Crashpad | Crashpad |
| `on_crash` hook (Windows) | Not supported | Supported | Supported |
| Sentry CLI | Manual download | Included | Included |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should say perhaps "Sentry CLI (automatic symbol upload)" or something? not sure just Sentry CLI here will suffice for folks who just landed in and are learning about this sdk.

perhaps a * next to the title and a clarification below to what this means. Do we create releases too? perhaps we use the CLI for other stuff also. @tustanivsky ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea of adding * - thanks for the tip!

Currently we're using Sentry CLI solely for debug symbol upload

| `on_crash` hook (Windows) | Not supported | Supported | Supported |
| Sentry CLI | Manual download | Included | Included |

### Installing from Fab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put this below the GH heading. Perhaps before we describe either we have a general recommendation. like:

"We recommend the GitHub release. Main advantages are: Crash reports uploaded immediately (crashpad), automatic symbol upload and larger range of supported UE versions. If you have a Blueprint only project you'd need to convert it to C++"


We recommend using the `github` version which uses `Crashpad`, an out-of-proc handler that sends the crash report right away. The `marketplace` version relies on `Breakpad`, an in-proc handler which requires the UE application or game to be relaunched in order to send the crash reports to Sentry.

### Build yourself
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PlasmaDev5 these details would be updated with your solution to build using the UÉ build system.

@bruno-garcia
Copy link
Member

testing the preview the new link didn't show up. Not sure if a vercel issue

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, but otherwise this looks good!

drguthals and others added 4 commits December 10, 2024 10:13
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@drguthals drguthals merged commit 4a1e509 into master Dec 10, 2024
11 checks passed
@drguthals drguthals deleted the unreal-marketplace-limitations branch December 10, 2024 18:42
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
* Create installation-recommendations.md

* Update installation-recommendations.md

* Update index.mdx

* Update installation-recommendations.md

* Update installation-recommendations.md

* Update index.mdx

* Update installation-recommendations.md

* Update docs/platforms/unreal/installation/installation-recommendations.md

* Moving GitHub releases to the top

* Moving installation to the main page

* Update docs/platforms/unreal/index.mdx

* Update docs/platforms/unreal/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/platforms/unreal/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/platforms/unreal/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

* Update docs/platforms/unreal/index.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>

---------

Co-authored-by: Ivan Tustanivskyi <tustanivsky@gmail.com>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants