Skip to content

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Dec 12, 2024

This adds a note that User Feedback requires browsers that support the Dialog element as we use the element + its APIs to show the feedback modal.

This adds a note that User Feedback requires browsers that support the [Dialog element](https://caniuse.com/mdn-html_elements_dialog) as we use the element + its APIs to show the feedback modal.
@vercel
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:28pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 4:28pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 4:28pm

@codecov
Copy link

codecov bot commented Dec 12, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

@billyvg billyvg merged commit bdb1d60 into master Dec 12, 2024
11 checks passed
@billyvg billyvg deleted the feat-feedback-add-note-about-dialog-el branch December 12, 2024 17:16
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
This adds a note that User Feedback requires browsers that support the [Dialog element](https://caniuse.com/mdn-html_elements_dialog) as we use the element + its APIs to show the feedback modal.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants