Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 13, 2024

DESCRIBE YOUR PR

This PR clarifies/expands on the impact and applicability of the synthetic flag in the exception mechanism:

  • adds impact on issue grouping
  • adds another concrete use case when to set the flag

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 8:30am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 8:30am
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 8:30am

@Lms24 Lms24 force-pushed the lms/ref-develop-synthetic branch from 6849505 to 085b30e Compare December 13, 2024 10:28
@Lms24 Lms24 force-pushed the lms/ref-develop-synthetic branch from 085b30e to 060f8af Compare December 13, 2024 10:28
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excuse the awful formatting here. The : x MD syntax seems to interpret line breaks differently to conventional paragraphs which means we have to explicitly break at specific words in order to retain somewhat nice paragraph blocks on the rendered page.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Katie Byers <katie.byers@sentry.io>
@Lms24 Lms24 enabled auto-merge (squash) December 16, 2024 08:25
@Lms24 Lms24 merged commit 2230ca7 into master Dec 16, 2024
10 checks passed
@Lms24 Lms24 deleted the lms/ref-develop-synthetic branch December 16, 2024 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants